test/util/daemon-socket-test.ts (view raw)
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 |
import { test, describe } from "node:test";
import assert from "node:assert/strict";
import { fileURLToPath } from "node:url";
import { existsSync, mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
import { tmpdir } from "node:os";
import { dirname, join } from "node:path";
import { Type } from "typebox";
import type { ExtensionAPI, ToolDefinition } from "@mariozechner/pi-coding-agent";
import type { TSchema } from "typebox";
import {
daemonNodeExecutable,
daemonSocketMayExist,
daemonSpawnCommand,
resolveTsxCliFromFilesystem,
} from "../../src/daemon/spawn";
import { type AnyBrowserToolDefinition, registerBrowserTool } from "../../src/util/tool";
import type { BrowserClient } from "../../src/client";
import { ok } from "../../src/util/result";
const WINDOWS_PIPE = "\\\\.\\pipe\\pi-browser-daemon";
const MISSING_SOCKET = "/pi-browser-harness/definitely/not/here.sock";
const thisFile = fileURLToPath(import.meta.url);
describe("daemon socket presence check", () => {
test("a Windows named pipe is never judged absent from the filesystem", async () => {
assert.equal(await daemonSocketMayExist("win32", WINDOWS_PIPE), true);
});
test("a missing POSIX socket path is judged absent", async () => {
assert.equal(await daemonSocketMayExist("linux", MISSING_SOCKET), false);
});
test("an existing POSIX path is judged present", async () => {
assert.equal(await daemonSocketMayExist("linux", thisFile), true);
});
test("darwin uses the filesystem like linux", async () => {
assert.equal(await daemonSocketMayExist("darwin", MISSING_SOCKET), false);
assert.equal(await daemonSocketMayExist("darwin", thisFile), true);
});
});
describe("daemon spawn command", () => {
test("the daemon runs on this process's node, not a shell", () => {
const spec = daemonSpawnCommand();
assert.notEqual(spec, null);
assert.equal(spec?.command, process.execPath);
});
test("the resolved tsx CLI is a real file on disk", () => {
const cli = daemonSpawnCommand()?.args[0];
assert.equal(typeof cli, "string");
// A hoisted install puts tsx beside the package, so a `<pkg>/node_modules/.bin` guess would miss it.
assert.equal(existsSync(String(cli)), true, `tsx CLI not found at ${String(cli)}`);
assert.match(String(cli), /cli\.mjs$/);
});
test("the daemon entrypoint is passed to tsx", () => {
const script = daemonSpawnCommand()?.args[1];
assert.match(String(script), /[\\/]daemon[\\/]index\.ts$/);
assert.equal(existsSync(String(script)), true);
});
});
describe("daemon node executable", () => {
const nodeVersions = { node: "22.0.0" };
const bunVersions = { node: "22.0.0", bun: "1.3.14" };
test("a plain Node host reuses its own executable", () => {
assert.equal(daemonNodeExecutable({}, nodeVersions, "linux", "/usr/bin/node"), "/usr/bin/node");
assert.equal(daemonNodeExecutable({}, nodeVersions, "win32", "C:\\node\\node.exe"), "C:\\node\\node.exe");
});
test("a Bun-compiled host never spawns itself as node", () => {
assert.equal(daemonNodeExecutable({}, bunVersions, "linux", "/opt/pi/pi"), "node");
assert.equal(daemonNodeExecutable({}, bunVersions, "darwin", "/opt/pi/pi"), "node");
assert.equal(daemonNodeExecutable({}, bunVersions, "win32", "C:\\pi\\pi.exe"), "node.exe");
});
test("PI_BROWSER_NODE overrides on every runtime", () => {
const env = { PI_BROWSER_NODE: "/custom/node" };
assert.equal(daemonNodeExecutable(env, nodeVersions, "linux", "/usr/bin/node"), "/custom/node");
assert.equal(daemonNodeExecutable(env, bunVersions, "win32", "C:\\pi\\pi.exe"), "/custom/node");
});
test("an empty PI_BROWSER_NODE is ignored", () => {
assert.equal(daemonNodeExecutable({ PI_BROWSER_NODE: "" }, bunVersions, "linux", "/opt/pi/pi"), "node");
});
});
const withTree = (prefix: string, fn: (root: string) => void): void => {
const root = mkdtempSync(join(tmpdir(), prefix));
try {
fn(root);
} finally {
rmSync(root, { recursive: true, force: true });
}
};
const touch = (file: string): void => {
mkdirSync(dirname(file), { recursive: true });
writeFileSync(file, "");
};
describe("tsx CLI filesystem fallback", () => {
// pi installs extensions into one flat tree, so tsx is a sibling of the package, not inside it.
test("finds a tsx hoisted beside the package, walking up from src/daemon", () => {
withTree("pbh-hoist-", (root) => {
const cli = join(root, "node_modules", "tsx", "dist", "cli.mjs");
touch(cli);
const start = join(root, "node_modules", "pi-browser-harness", "src", "daemon");
mkdirSync(start, { recursive: true });
assert.equal(resolveTsxCliFromFilesystem(start), cli);
});
});
test("prefers the package's own node_modules over a hoisted copy", () => {
withTree("pbh-local-", (root) => {
const hoisted = join(root, "node_modules", "tsx", "dist", "cli.mjs");
const local = join(root, "node_modules", "pi-browser-harness", "node_modules", "tsx", "dist", "cli.mjs");
touch(hoisted);
touch(local);
const start = join(root, "node_modules", "pi-browser-harness", "src", "daemon");
mkdirSync(start, { recursive: true });
assert.equal(resolveTsxCliFromFilesystem(start), local);
});
});
test("the fallback agrees with Node's resolver in this checkout", () => {
const viaResolver = daemonSpawnCommand()?.args[0];
assert.equal(resolveTsxCliFromFilesystem(), viaResolver);
});
});
type GateProbe = { readonly ran: ReadonlyArray<string>; readonly text: string };
const runGate = async (ensureAlive: boolean | undefined): Promise<GateProbe> => {
const ran: string[] = [];
const client = {
mutationMutex: () => ({ acquire: async () => () => {} }),
ensureAlive: async () => ok(undefined),
} as unknown as BrowserClient;
const def = {
name: "browser_probe",
label: "Probe",
description: "probe",
promptSnippet: "probe",
promptGuidelines: [],
parameters: Type.Object({}),
concurrency: "parallel",
...(ensureAlive !== undefined ? { ensureAlive } : {}),
handler: async () => {
ran.push("handler");
return ok({ text: "done" });
},
} as AnyBrowserToolDefinition;
let registered: ToolDefinition<TSchema> | undefined;
const pi = {
registerTool: (td: ToolDefinition<TSchema>) => {
registered = td;
},
} as unknown as ExtensionAPI;
registerBrowserTool(pi, client, def);
assert.ok(registered, "tool was not registered");
const result = await registered.execute?.("id", {}, undefined, undefined, undefined as never);
const first = result?.content[0];
return { ran, text: first !== undefined && first.type === "text" ? first.text : "" };
};
describe("tool gate on the daemon socket", () => {
test("ensureAlive:false bypasses the gate entirely", async () => {
const probe = await runGate(false);
assert.deepEqual([...probe.ran], ["handler"]);
assert.equal(probe.text, "done");
});
test("a gated tool agrees with the socket check about reaching the handler", async () => {
const reachable = await daemonSocketMayExist();
const probe = await runGate(undefined);
if (reachable) assert.deepEqual([...probe.ran], ["handler"]);
else {
assert.deepEqual([...probe.ran], []);
assert.match(probe.text, /not initialized/);
}
});
});
|